[PATCH v2 4/8] soc: mediatek: mtk-cmdq: Add pa_base parsing for unsupported subsys ID hardware

[Jason-JH . Lin]

When GCE executes instructions, the corresponding hardware register
can be found through the subsys ID. For hardware that does not support
subsys IDs, the physical address needs to be used to generate GCE
instructions.

This commit adds a pa_base parsing flow to the cmdq_client_reg structure
for these unsupported subsys ID hardware.

Signed-off-by: Jason-JH.Lin <jason-jh....@mediatek.com>
---
 drivers/soc/mediatek/mtk-cmdq-helper.c | 18 ++++++++++++++++--
 include/linux/soc/mediatek/mtk-cmdq.h  |  1 +
 2 files changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-cmdq-helper.c 
b/drivers/soc/mediatek/mtk-cmdq-helper.c
index 0a05ee87a0fc..87734639c37c 100644
--- a/drivers/soc/mediatek/mtk-cmdq-helper.c
+++ b/drivers/soc/mediatek/mtk-cmdq-helper.c
@@ -8,6 +8,7 @@
 #include <linux/module.h>
 #include <linux/mailbox_controller.h>
 #include <linux/of.h>
+#include <linux/of_address.h>
 #include <linux/soc/mediatek/mtk-cmdq.h>
 
 #define CMDQ_WRITE_ENABLE_MASK BIT(0)
@@ -60,20 +61,30 @@ int cmdq_dev_get_client_reg(struct device *dev,
                            struct cmdq_client_reg *client_reg, int idx)
 {
        struct of_phandle_args spec;
+       struct resource res;
        int err;
 
        if (!client_reg)
                return -ENOENT;
 
+       if (of_address_to_resource(dev->of_node, 0, &res) != 0) {
+               dev_err(dev, "Missing reg in %s node\n", 
dev->of_node->full_name);
+               return -EINVAL;
+       }
+       client_reg->pa_base = res.start;
+
        err = of_parse_phandle_with_fixed_args(dev->of_node,
                                               "mediatek,gce-client-reg",
                                               3, idx, &spec);
        if (err < 0) {
-               dev_warn(dev,
+               dev_dbg(dev,
                        "error %d can't parse gce-client-reg property (%d)",
                        err, idx);
 
-               return err;
+               /* make subsys invalid */
+               client_reg->subsys = U8_MAX;
+
+               return 0;
        }
 
        client_reg->subsys = (u8)spec.args[0];
@@ -130,6 +141,9 @@ int cmdq_pkt_create(struct cmdq_client *client, struct 
cmdq_pkt *pkt, size_t siz
 
        pkt->buf_size = size;
 
+       /* need to use pkt->cl->chan later to call mbox APIs when generating 
instruction */
+       pkt->cl = (void *)client;
+
        dev = client->chan->mbox->dev;
        dma_addr = dma_map_single(dev, pkt->va_base, pkt->buf_size,
                                  DMA_TO_DEVICE);
diff --git a/include/linux/soc/mediatek/mtk-cmdq.h 
b/include/linux/soc/mediatek/mtk-cmdq.h
index 5bee6f7fc400..d925f9dc7987 100644
--- a/include/linux/soc/mediatek/mtk-cmdq.h
+++ b/include/linux/soc/mediatek/mtk-cmdq.h
@@ -52,6 +52,7 @@ struct cmdq_operand {
 
 struct cmdq_client_reg {
        u8 subsys;
+       u32 pa_base;
        u16 offset;
        u16 size;
 };
-- 
2.43.0