On Thu, Dec 05, 2024 at 08:32:02PM -0800, Abhinav Kumar wrote:
> Add a new file dp_mst_drm to manage the DP MST bridge operations
> similar to the dp_drm file which manages the SST bridge operations.
> Each MST encoder creates one bridge and each bridge is bound to its
> own dp_panel abstraction to manage the operations of its pipeline.
>
> Signed-off-by: Abhinav Kumar <quic_abhin...@quicinc.com>
> ---
> drivers/gpu/drm/msm/Makefile | 3 +-
> drivers/gpu/drm/msm/dp/dp_display.h | 2 +
> drivers/gpu/drm/msm/dp/dp_mst_drm.c | 490
> ++++++++++++++++++++++++++++++++++++
> drivers/gpu/drm/msm/dp/dp_mst_drm.h | 102 ++++++++
> 4 files changed, 596 insertions(+), 1 deletion(-)
>
> +
> +struct msm_dp_mst_bridge {
> + struct drm_bridge base;
> + struct drm_private_obj obj;
it occured to me, while reviewing the next patch. Why do you need
another drm_private_obj???
> + u32 id;
> +
> + bool in_use;
> +
> + struct msm_dp *display;
> + struct drm_encoder *encoder;
> +
> + struct drm_display_mode drm_mode;
> + struct msm_dp_display_mode msm_dp_mode;
> + struct drm_connector *connector;
> + struct msm_dp_panel *msm_dp_panel;
> +
> + int vcpi;
> + int pbn;
> + int num_slots;
> + int start_slot;
> +};
--
With best wishes
Dmitry
