On 10/14/2024, Dmitry Baryshkov wrote:
> On Sun, Oct 13, 2024 at 10:48:54AM +0000, Biju Das wrote:
[...]
>>>>> +static int it6263_bridge_attach(struct drm_bridge *bridge,
>>>>> + enum drm_bridge_attach_flags flags) {
>>>>> + struct it6263 *it = bridge_to_it6263(bridge);
>>>>> + int ret;
>>>>> +
>>>>> + ret = drm_bridge_attach(bridge->encoder, it->next_bridge, bridge,
>>>>> + flags | DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>>>>> + if (ret < 0)
>>>>> + return ret;
>>>>> +
>>>>> + if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>>>>> + return 0;
>>>>> +
>>>>> + it->connector.polled = DRM_CONNECTOR_POLL_CONNECT |
>>>>> + DRM_CONNECTOR_POLL_DISCONNECT;
>>>>> +
>>>>
>>>> Please strongly consider dropping this and using drm_bridge_connector
>>>> in the host driver.
>>>
>>> I can't afford to make i.MX8MP imx-lcdif KMS use drm_bridge_connector
>>> currently. Maybe the Renesas
>>> RZ/G3E SMARC EVK Biju tested v1 patch set with is also not using
>>> drm_bridge_connector. I hope we can
>>> leave it as-is for now.
>>
>> Renesas platform use the drm_bridge_connector_init() helper to create a
>> drm_connector for
>> each output, instead of relying on the bridge drivers doing so. It attach
>> the bridges with the DRM_BRIDGE_ATTACH_NO_CONNECTOR flag to instruct
>> them not to create a connector.
>>
>> On Renesas platform, it exit from here
>> if (flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)
>> return 0;
>>
>> Maybe it is good to have both cases to start with. Add support for both
>> cases now,
>> Later when imx-lcdif KMS start using drm_bridge_connector,
>> we can start dropping bridge devices to create connector??
>
> Do we have a timeline for this?
I sent out a patch series to make i.MX LCDIF driver use
drm_bridge_connector just now.
https://patchwork.freedesktop.org/series/140148/
--
Regards,
Liu Ying
