Re: [PATCH 2/2] drm/ast: vga: Clear EDID if no display is connected

[Jocelyn Falempe]

On 15/10/2024 08:49, Thomas Zimmermann wrote:

Do not keep the obsolete EDID around after unplugging the display
from the connector.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Fixes: 2a2391f857cd ("drm/ast: vga: Transparently handle BMC support")
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Jocelyn Falempe <jfale...@redhat.com>
Cc: Dave Airlie <airl...@redhat.com>
Cc: dri-devel@lists.freedesktop.org
---
  drivers/gpu/drm/ast/ast_vga.c | 2 ++
  1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/ast/ast_vga.c b/drivers/gpu/drm/ast/ast_vga.c
index 5c79b773af57..abe0fff8485c 100644
--- a/drivers/gpu/drm/ast/ast_vga.c
+++ b/drivers/gpu/drm/ast/ast_vga.c
@@ -29,6 +29,8 @@ static int ast_vga_connector_helper_get_modes(struct 
drm_connector *connector)
        if (ast_connector->physical_status == connector_status_connected) {
                count = drm_connector_helper_get_modes(connector);
        } else {
+               drm_edid_connector_update(connector, NULL);
+
                /*
                 * There's no EDID data without a connected monitor. Set BMC-
                 * compatible modes in this case. The XGA default resolution