Re: [PATCH 4/5] drm: Select fbdev helpers for modules that require them

[Jocelyn Falempe]

On 27/09/2024 16:37, Thomas Zimmermann wrote:

Fbdev emulation for SHMEM and TTM requires helpers from the fbdev
subsystem. Select them from the modules that use them instead of the
core DRM module.

Thanks, it looks good to me.

Reviewed-by: Jocelyn Falempe <jfale...@redhat.com>

Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
---
  drivers/gpu/drm/Kconfig | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
index 1df4e627e3d3..88b2ba55fe16 100644
--- a/drivers/gpu/drm/Kconfig
+++ b/drivers/gpu/drm/Kconfig
@@ -11,7 +11,6 @@ menuconfig DRM
        select DRM_PANEL_ORIENTATION_QUIRKS
        select DRM_KMS_HELPER if DRM_FBDEV_EMULATION
        select FB_CORE if DRM_FBDEV_EMULATION
-       select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
        select HDMI
        select I2C
        select DMA_SHARED_BUFFER
@@ -332,6 +331,7 @@ config DRM_TTM_HELPER
        tristate
        depends on DRM
        select DRM_TTM
+       select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
        help
          Helpers for ttm-based gem objects

@@ -345,6 +345,7 @@ config DRM_GEM_DMA_HELPER

  config DRM_GEM_SHMEM_HELPER
        tristate
        depends on DRM && MMU
+       select FB_SYSMEM_HELPERS_DEFERRED if DRM_FBDEV_EMULATION
        help
          Choose this if you need the GEM shmem helper functions