Hi Louis,
> CRTC initialization call drm_mode_crtc_set_gamma_size without the proper
> checks, introduce this check to avoid issues.
>
> Signed-off-by: Louis Chauvet <louis.chau...@bootlin.com>
Reviewed-by: José Expósito <jose.exposit...@gmail.com>
> ---
> drivers/gpu/drm/vkms/vkms_crtc.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
>
> ---
> base-commit: a6bb1f77a94335de67dba12e7f52651c115b82d2
> change-id: 20240906-vkms-add-missing-check-e1b6ee8d1b39
>
> Best regards,
>
> diff --git a/drivers/gpu/drm/vkms/vkms_crtc.c
> b/drivers/gpu/drm/vkms/vkms_crtc.c
> index 40b4d084e3ce..e4f93dfbd071 100644
> --- a/drivers/gpu/drm/vkms/vkms_crtc.c
> +++ b/drivers/gpu/drm/vkms/vkms_crtc.c
> @@ -287,7 +287,12 @@ int vkms_crtc_init(struct drm_device *dev, struct
> drm_crtc *crtc,
>
> drm_crtc_helper_add(crtc, &vkms_crtc_helper_funcs);
>
> - drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
> + ret = drm_mode_crtc_set_gamma_size(crtc, VKMS_LUT_SIZE);
> + if (ret) {
> + DRM_ERROR("Failed to set gamma size\n");
This will conflit with "drm/vkms: Switch to dynamic allocation
for CRTC" [1], where you switched to DRM_DEV_ERROR.
No proferences about the log function, just a heads up so when
you rebase one of the patches we keep logging consistent.
[1]
https://patchwork.kernel.org/project/dri-devel/patch/20240912-b4-vkms-allocated-v1-3-29abbaa14...@bootlin.com/
> + return ret;
> + }
> +
> drm_crtc_enable_color_mgmt(crtc, 0, false, VKMS_LUT_SIZE);
>
> spin_lock_init(&vkms_out->lock);
>
