On 8/1/24 6:37 AM, Rob Herring (Arm) wrote: > > On Thu, 01 Aug 2024 05:25:52 +0300, Cristian Ciocaltea wrote: >> Rockchip RK3588 SoC integrates the Synopsys DesignWare HDMI 2.1 >> Quad-Pixel (QP) TX controller IP. >> >> Since this is a new IP block, quite different from those used in the >> previous generations of Rockchip SoCs, add a dedicated binding file. >> >> Signed-off-by: Cristian Ciocaltea <cristian.ciocal...@collabora.com> >> --- >> .../display/rockchip/rockchip,dw-hdmi-qp.yaml | 188 >> +++++++++++++++++++++ >> 1 file changed, 188 insertions(+) >> > > My bot found errors running 'make dt_binding_check' on your patch:
This is because the referenced synopsys,dw-hdmi-qp.yaml is provided by a separate patchset: https://lore.kernel.org/lkml/20240801-dw-hdmi-qp-tx-v1-1-148f542de...@collabora.com/ > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi-qp.example.dtb: > hdmi@fde80000: False schema does not allow {'compatible': > ['rockchip,rk3588-dw-hdmi-qp'], 'reg': [[0, 4259840000, 0, 131072]], > 'clocks': [[4294967295, 528], [4294967295, 529], [4294967295, 530], > [4294967295, 564], [4294967295, 594], [4294967295, 717]], 'clock-names': > ['pclk', 'earc', 'ref', 'aud', 'hdp', 'hclk_vo1'], 'interrupts': [[0, 169, 4, > 0], [0, 170, 4, 0], [0, 171, 4, 0], [0, 172, 4, 0], [0, 360, 4, 0]], > 'interrupt-names': ['avp', 'cec', 'earc', 'main', 'hpd'], 'phys': > [[4294967295]], 'phy-names': ['hdmi'], 'power-domains': [[4294967295, 26]], > 'resets': [[4294967295, 462], [4294967295, 560]], 'reset-names': ['ref', > 'hdp'], 'rockchip,grf': [[4294967295]], 'rockchip,vo1_grf': [[4294967295]], > '#sound-dai-cells': 0, 'ports': {'#address-cells': 1, '#size-cells': 0, > 'port@0': {'reg': [[0]], 'endpoint': {'remote-endpoint': [[4294967295]]}}, > 'port@1': {'reg': [[1]] > , 'endpoint': {'remote-endpoint': [[4294967295]]}}}, '$nodename': > ['hdmi@fde80000']} > from schema $id: > http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi-qp.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/rockchip/rockchip,dw-hdmi-qp.example.dtb: > hdmi@fde80000: Unevaluated properties are not allowed ('reg' was unexpected) > from schema $id: > http://devicetree.org/schemas/display/rockchip/rockchip,dw-hdmi-qp.yaml# > > doc reference errors (make refcheckdocs): > > See > https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240801-b4-rk3588-bridge-upstream-v2-1-9fa657a4e...@collabora.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
