From: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>

If userspace provides an unknown or invalid handle anywhere in the handle
array the rest of the driver will not handle that well.

Fix it by checking handle was looked up successfuly or otherwise fail the
extension by jumping into the existing unwind.

Signed-off-by: Tvrtko Ursulin <tvrtko.ursu...@igalia.com>
Fixes: bae7cb5d6800 ("drm/v3d: Create a CPU job extension for the reset 
performance query job"
Cc: Maíra Canal <mca...@igalia.com>
Cc: Iago Toral Quiroga <ito...@igalia.com>
Cc: <sta...@vger.kernel.org> # v6.8+
---
 drivers/gpu/drm/v3d/v3d_submit.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/drivers/gpu/drm/v3d/v3d_submit.c b/drivers/gpu/drm/v3d/v3d_submit.c
index e3a00c8394a5..3838ebade45d 100644
--- a/drivers/gpu/drm/v3d/v3d_submit.c
+++ b/drivers/gpu/drm/v3d/v3d_submit.c
@@ -710,6 +710,10 @@ v3d_get_cpu_reset_performance_params(struct drm_file 
*file_priv,
                }
 
                job->performance_query.queries[i].syncobj = 
drm_syncobj_find(file_priv, sync);
+               if (!job->performance_query.queries[i].syncobj) {
+                       err = -ENOENT;
+                       goto error;
+               }
        }
        job->performance_query.count = reset.count;
        job->performance_query.nperfmons = reset.nperfmons;
@@ -790,6 +794,10 @@ v3d_get_cpu_copy_performance_query_params(struct drm_file 
*file_priv,
                }
 
                job->performance_query.queries[i].syncobj = 
drm_syncobj_find(file_priv, sync);
+               if (!job->performance_query.queries[i].syncobj) {
+                       err = -ENOENT;
+                       goto error;
+               }
        }
        job->performance_query.count = copy.count;
        job->performance_query.nperfmons = copy.nperfmons;
-- 
2.44.0

Reply via email to