On Wed, Jun 2, 2010 at 7:55 AM, Julien Cristau <jcristau at debian.org> wrote: > On Tue, Jun ?1, 2010 at 18:52:30 -0400, Alex Deucher wrote: > >> diff --git a/drivers/gpu/drm/radeon/Kconfig b/drivers/gpu/drm/radeon/Kconfig >> index 80c5b3e..2e3896d 100644 >> --- a/drivers/gpu/drm/radeon/Kconfig >> +++ b/drivers/gpu/drm/radeon/Kconfig >> @@ -2,6 +2,7 @@ config DRM_RADEON_KMS >> ? ? ? bool "Enable modesetting on radeon by default - NEW DRIVER" >> ? ? ? depends on DRM_RADEON >> ? ? ? depends on POWER_SUPPLY >> + ? ? depends on HWMON >> ? ? ? help >> ? ? ? ? Choose this option if you want kernel modesetting enabled by default. >> > Shouldn't these be under CONFIG_DRM_RADEON, with _KMS only changing the > default value of the modeset parameter? ?Otherwise you could still try > to build the driver with _KMS off, and CONFIG_HWMON disabled (which I > assume is going to fail).
Yes, I patched an old version of the tree without this patch: http://git.kernel.org/?p=linux/kernel/git/airlied/drm-2.6.git;a=commitdiff;h=5d9b7e2d2db95549aeab129c95d588236137a4c8 I'll update the patch. > > Cheers, > Julien >