Re: [PATCH 9/9] accel/rocket: Add IOCTLs for synchronizing memory accesses

[Jeffrey Hugo]

On 6/12/2024 7:53 AM, Tomeu Vizoso wrote:
diff --git a/include/uapi/drm/rocket_accel.h b/include/uapi/drm/rocket_accel.h
index 888c9413e4cd..1539af0af4fe 100644
--- a/include/uapi/drm/rocket_accel.h
+++ b/include/uapi/drm/rocket_accel.h
@@ -12,9 +12,13 @@ extern "C" {
  #endif
  
  #define DRM_ROCKET_CREATE_BO			0x00
-#define DRM_ROCKET_SUBMIT                      0x01
+#define DRM_ROCKET_PREP_BO                     0x01
+#define DRM_ROCKET_FINI_BO                     0x02
+#define DRM_ROCKET_SUBMIT                      0x03

This looks like a uAPI breaking change.  Shouldn't you have defined 
SUBMIT as 0x03 from the beginning, or put the new BO ioctls after it?