> -----Original Message-----
> From: Tomi Valkeinen <tomi.valkei...@ideasonboard.com>
> Sent: Thursday, April 25, 2024 11:36 PM
> To: Klymenko, Anatoliy <anatoliy.klyme...@amd.com>
> Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org;
> linux-ker...@vger.kernel.org; kernel test robot <l...@intel.com>; Laurent
> Pinchart <laurent.pinch...@ideasonboard.com>; Maarten Lankhorst
> <maarten.lankho...@linux.intel.com>; Maxime Ripard
> <mrip...@kernel.org>; Thomas Zimmermann <tzimmerm...@suse.de>;
> David Airlie <airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>;
> Simek, Michal <michal.si...@amd.com>
> Subject: Re: [PATCH v2 2/2] drm: xlnx: zynqmp_dpsub: Fix compilation
> error
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On 26/04/2024 04:46, Anatoliy Klymenko wrote:
> > Fix W=1 clang 19 compilation error in
> zynqmp_disp_layer_drm_formats().
> >
> > Reported-by: kernel test robot <l...@intel.com>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202404260946.4oZXvHD2-
> l...@intel.com/
> > ---
>
> This is missing your signed-off-by.
>
> Tomi
Thank you!
>
> > drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > index 423f5f4943cc..c9fb432d4cbd 100644
> > --- a/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp.c
> > @@ -981,7 +981,7 @@ u32 *zynqmp_disp_layer_drm_formats(struct
> zynqmp_disp_layer *layer,
> > unsigned int i;
> > u32 *formats;
> >
> > - if (WARN_ON(!layer->mode == ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> > + if (WARN_ON(layer->mode != ZYNQMP_DPSUB_LAYER_NONLIVE)) {
> > *num_formats = 0;
> > return NULL;
> > }
> >
