On 22/04/2024 16:34, Johan Adolfsson wrote: > > > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org> > Sent: den 19 april 2024 01:05 > To: Johan Adolfsson <johan.adolfs...@axis.com>; Neil Armstrong > <neil.armstr...@linaro.org>; Jessica Zhang <quic_jessz...@quicinc.com>; Sam > Ravnborg <s...@ravnborg.org>; Maarten Lankhorst > <maarten.lankho...@linux.intel.com>; Maxime Ripard <mrip...@kernel.org>; > Thomas Zimmermann <tzimmerm...@suse.de>; David Airlie <airl...@gmail.com>; > Daniel Vetter <dan...@ffwll.ch>; Rob Herring <robh...@kernel.org>; Krzysztof > Kozlowski <krzysztof.kozlowski...@linaro.org>; Conor Dooley > <conor...@kernel.org>; Thierry Reding <thierry.red...@gmail.com> > Cc: dri-devel@lists.freedesktop.org; linux-ker...@vger.kernel.org; > devicet...@vger.kernel.org; kernel <ker...@axis.com> > Subject: Re: [PATCH 2/2] dt-bindings: panel-simple-dsi: Add generic panel-dsi > >> On 18/04/2024 16:01, Johan Adolfsson wrote: >>> panel-dsi is similar to panel-dpi with overridable timings >> >> ??? > > I guess a more correct description would be > "panel-dsi is a fallback in a similar way that panel-dpi is in panel-dpi.yaml > .."?
I meant how does it explain the hardware. > > ... >>> a/Documentation/devicetree/bindings/display/panel/panel-simple-dsi.yam >>> l >>> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-dsi >>> +++ .yaml >>> @@ -56,6 +56,8 @@ properties: >>> - samsung,sofef00 >>> # Shangai Top Display Optoelectronics 7" TL070WSH30 1024x600 TFT >>> LCD panel >>> - tdo,tl070wsh30 >>> + # Generic dsi panel with timing overridable >>> + - panel-dsi >> >> ? Devices are not generic. This is very confusing and commit msg does not >> help me. Compatibles *must* be specific, see writing-bindings. > > I guess I see this a generic fallback, that handles any dsi panel as long as > the correct timing etc is specified in devictree, similar to what panel-dpi > is in panel-dpi.yaml > Maybe phrasing it similar to panel-dpi.yaml is better? But panel-dpi is quite different. You always have two compatibles. I don't see two compatibles here. Best regards, Krzysztof
