Hi Thomas,

kernel test robot noticed the following build warnings:

[auto build test WARNING on drm-xe/drm-xe-next]
[also build test WARNING on drm-intel/for-linux-next-fixes drm-tip/drm-tip 
linus/master v6.9-rc4 next-20240416]
[cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next 
drm-intel/for-linux-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    
https://github.com/intel-lab-lkp/linux/commits/Thomas-Hellstr-m/drm-ttm-Allow-TTM-LRU-list-nodes-of-different-types/20240416-181717
base:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
patch link:    
https://lore.kernel.org/r/20240416100730.6666-10-thomas.hellstrom%40linux.intel.com
patch subject: [PATCH v2 9/9] drm/xe: Add a shrinker for xe bos
config: i386-buildonly-randconfig-001-20240417 
(https://download.01.org/0day-ci/archive/20240417/202404170528.tbjgqkcr-...@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 
6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): 
(https://download.01.org/0day-ci/archive/20240417/202404170528.tbjgqkcr-...@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <l...@intel.com>
| Closes: 
https://lore.kernel.org/oe-kbuild-all/202404170528.tbjgqkcr-...@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/gpu/drm/xe/xe_bo.c:2420:
>> drivers/gpu/drm/xe/tests/xe_bo.c:382:6: warning: format specifies type 
>> 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') 
>> [-Wformat]
     381 |         kunit_info(test, "Free ram is %lu bytes. Will allocate twice 
of that.\n",
         |                                       ~~~
         |                                       %zu
     382 |                    total);
         |                    ^~~~~
   include/kunit/test.h:546:39: note: expanded from macro 'kunit_info'
     546 |         kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
         |                                       ~~~    ^~~~~~~~~~~
   include/kunit/test.h:534:21: note: expanded from macro 'kunit_printk'
     533 |         kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt,      
   \
         |                                                            ~~~
     534 |                   (test)->name, ##__VA_ARGS__)
         |                                   ^~~~~~~~~~~
   include/kunit/test.h:527:21: note: expanded from macro 'kunit_log'
     527 |                 printk(lvl fmt, ##__VA_ARGS__);                      
   \
         |                            ~~~    ^~~~~~~~~~~
   include/linux/printk.h:457:60: note: expanded from macro 'printk'
     457 | #define printk(fmt, ...) printk_index_wrap(_printk, fmt, 
##__VA_ARGS__)
         |                                                     ~~~    
^~~~~~~~~~~
   include/linux/printk.h:429:19: note: expanded from macro 'printk_index_wrap'
     429 |                 _p_func(_fmt, ##__VA_ARGS__);                        
   \
         |                         ~~~~    ^~~~~~~~~~~
   In file included from drivers/gpu/drm/xe/xe_bo.c:2420:
>> drivers/gpu/drm/xe/tests/xe_bo.c:382:6: warning: format specifies type 
>> 'unsigned long' but the argument has type 'size_t' (aka 'unsigned int') 
>> [-Wformat]
     381 |         kunit_info(test, "Free ram is %lu bytes. Will allocate twice 
of that.\n",
         |                                       ~~~
         |                                       %zu
     382 |                    total);
         |                    ^~~~~
   include/kunit/test.h:546:39: note: expanded from macro 'kunit_info'
     546 |         kunit_printk(KERN_INFO, test, fmt, ##__VA_ARGS__)
         |                                       ~~~    ^~~~~~~~~~~
   include/kunit/test.h:534:21: note: expanded from macro 'kunit_printk'
     533 |         kunit_log(lvl, test, KUNIT_SUBTEST_INDENT "# %s: " fmt,      
   \
         |                                                            ~~~
     534 |                   (test)->name, ##__VA_ARGS__)
         |                                   ^~~~~~~~~~~
   include/kunit/test.h:529:8: note: expanded from macro 'kunit_log'
     528 |                 kunit_log_append((test_or_suite)->log,  fmt,         
   \
         |                                                         ~~~
     529 |                                  ##__VA_ARGS__);                     
   \
         |                                    ^~~~~~~~~~~
   2 warnings generated.


vim +382 drivers/gpu/drm/xe/tests/xe_bo.c

   362  
   363  /*
   364   * Try to create system bos corresponding to twice the amount
   365   * of available system memory to test shrinker functionality.
   366   * If no swap space is available to accommodate the
   367   * memory overcommit, mark bos purgeable.
   368   */
   369  static int shrink_test_run_device(struct xe_device *xe)
   370  {
   371          struct kunit *test = xe_cur_kunit();
   372          LIST_HEAD(bos);
   373          struct xe_bo_link *link, *next;
   374          struct sysinfo si;
   375          size_t total, alloced;
   376          unsigned int interrupted = 0, successful = 0;
   377  
   378          si_meminfo(&si);
   379          total = si.freeram * si.mem_unit;
   380  
   381          kunit_info(test, "Free ram is %lu bytes. Will allocate twice of 
that.\n",
 > 382                     total);
   383  
   384          total <<= 1;
   385          for (alloced = 0; alloced < total ; alloced += 
XE_BO_SHRINK_SIZE) {
   386                  struct xe_bo *bo;
   387                  unsigned int mem_type;
   388  
   389                  link = kzalloc(sizeof(*link), GFP_KERNEL);
   390                  if (!link) {
   391                          KUNIT_FAIL(test, "Unexpeced link allocation 
failure\n");
   392                          break;
   393                  }
   394  
   395                  INIT_LIST_HEAD(&link->link);
   396  
   397                  /* We can create bos using WC caching here. But it is 
slower. */
   398                  bo = xe_bo_create_user(xe, NULL, NULL, 
XE_BO_SHRINK_SIZE,
   399                                         DRM_XE_GEM_CPU_CACHING_WB,
   400                                         ttm_bo_type_device,
   401                                         XE_BO_FLAG_SYSTEM);
   402                  if (IS_ERR(bo)) {
   403                          if (bo != ERR_PTR(-ENOMEM) && bo != 
ERR_PTR(-ENOSPC) &&
   404                              bo != ERR_PTR(-EINTR) && bo != 
ERR_PTR(-ERESTARTSYS))
   405                                  KUNIT_FAIL(test, "Error creating bo: 
%pe\n", bo);
   406                          kfree(link);
   407                          break;
   408                  }
   409                  link->bo = bo;
   410                  list_add_tail(&link->link, &bos);
   411                  xe_bo_lock(bo, false);
   412  
   413                  /*
   414                   * If we're low on swap entries, we can't shrink unless 
the bo
   415                   * is marked purgeable.
   416                   */
   417                  if (get_nr_swap_pages() < (XE_BO_SHRINK_SIZE >> 
PAGE_SHIFT) * 128) {
   418                          struct xe_ttm_tt *xe_tt =
   419                                  container_of(bo->ttm.ttm, 
typeof(*xe_tt), ttm);
   420                          long num_pages = xe_tt->ttm.num_pages;
   421  
   422                          xe_tt->purgeable = true;
   423                          xe_shrinker_mod_pages(xe->mem.shrinker, 
-num_pages,
   424                                                num_pages);
   425                  }
   426  
   427                  mem_type = bo->ttm.resource->mem_type;
   428                  xe_bo_unlock(bo);
   429                  if (mem_type != XE_PL_TT)
   430                          KUNIT_FAIL(test, "Bo in incorrect memory type: 
%u\n",
   431                                     bo->ttm.resource->mem_type);
   432                  cond_resched();
   433                  if (signal_pending(current))
   434                          break;
   435          }
   436  
   437          /* Read back and destroy bos */
   438          list_for_each_entry_safe_reverse(link, next, &bos, link) {
   439                  static struct ttm_operation_ctx ctx = {.interruptible = 
true};
   440                  struct xe_bo *bo = link->bo;
   441                  int ret;
   442  
   443                  if (!signal_pending(current)) {
   444                          xe_bo_lock(bo, NULL);
   445                          ret = ttm_bo_validate(&bo->ttm, &tt_placement, 
&ctx);
   446                          xe_bo_unlock(bo);
   447                          if (ret && ret != -EINTR)
   448                                  KUNIT_FAIL(test, "Validation failed: 
%pe\n",
   449                                             ERR_PTR(ret));
   450                          else if (ret)
   451                                  interrupted++;
   452                          else
   453                                  successful++;
   454                  }
   455                  xe_bo_put(link->bo);
   456                  list_del(&link->link);
   457                  kfree(link);
   458                  cond_resched();
   459          }
   460          kunit_info(test, "Readbacks interrupted: %u successful: %u\n",
   461                     interrupted, successful);
   462  
   463          return 0;
   464  }
   465  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Reply via email to