> -----Original Message----- > From: Tomi Valkeinen <tomi.valkei...@ideasonboard.com> > Sent: Friday, April 5, 2024 5:10 AM > To: Klymenko, Anatoliy <anatoliy.klyme...@amd.com> > Cc: dri-devel@lists.freedesktop.org; linux-arm-ker...@lists.infradead.org; > linux-ker...@vger.kernel.org; devicet...@vger.kernel.org; linux- > me...@vger.kernel.org; Laurent Pinchart > <laurent.pinch...@ideasonboard.com>; Maarten Lankhorst > <maarten.lankho...@linux.intel.com>; Maxime Ripard > <mrip...@kernel.org>; Thomas Zimmermann <tzimmerm...@suse.de>; > David Airlie <airl...@gmail.com>; Daniel Vetter <dan...@ffwll.ch>; > Simek, Michal <michal.si...@amd.com>; Andrzej Hajda > <andrzej.ha...@intel.com>; Neil Armstrong > <neil.armstr...@linaro.org>; Robert Foss <rf...@kernel.org>; Jonas > Karlman <jo...@kwiboo.se>; Jernej Skrabec > <jernej.skra...@gmail.com>; Rob Herring <robh...@kernel.org>; > Krzysztof Kozlowski <krzysztof.kozlowski...@linaro.org>; Conor Dooley > <conor...@kernel.org>; Mauro Carvalho Chehab > <mche...@kernel.org> > Subject: Re: [PATCH v3 2/9] drm: xlnx: zynqmp_dpsub: Update live format > defines > > Caution: This message originated from an External Source. Use proper > caution when opening attachments, clicking links, or responding. > > > On 21/03/2024 22:43, Anatoliy Klymenko wrote: > > Update live format defines to match DPSUB AV_BUF_LIVE_VID_CONFIG > register > > layout. > > I think this description needs a bit more. Mention that the defines are > not currently used, so we can change them like this without any other > change. >
Makes sense. I'll update this. > Tomi > > > Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > Signed-off-by: Anatoliy Klymenko <anatoliy.klyme...@amd.com> > > --- > > drivers/gpu/drm/xlnx/zynqmp_disp_regs.h | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > index f92a006d5070..fa3935384834 100644 > > --- a/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > +++ b/drivers/gpu/drm/xlnx/zynqmp_disp_regs.h > > @@ -165,10 +165,10 @@ > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_10 0x2 > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_12 0x3 > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_BPC_MASK > GENMASK(2, 0) > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_RGB 0x0 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV444 0x1 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV422 0x2 > > -#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YONLY 0x3 > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_RGB (0x0 > << 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV444 (0x1 << > 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YUV422 (0x2 << > 4) > > +#define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_YONLY (0x3 << > 4) > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_FMT_MASK > GENMASK(5, 4) > > #define ZYNQMP_DISP_AV_BUF_LIVE_CONFIG_CB_FIRST BIT(8) > > #define ZYNQMP_DISP_AV_BUF_PALETTE_MEMORY 0x400 > >
