On Mon, 20 Dec 2010 10:10:09 +1000 Dave Airlie <airlied at gmail.com> wrote:
> - * @change_bridge: traverse ancestors and change bridges > + * @change_bridge_flags: traverse ancestors and change bridges > + * CHANGE_BRIDGE_ONLY / CHANGE_BRIDGE > */ > int pci_set_vga_state(struct pci_dev *dev, bool decode, > - unsigned int command_bits, bool change_bridge) > + unsigned int command_bits, u32 flags) > { Other than this nitpick, it looks sound to me; we'll need to actually disable VGA decode in the shared bridge hierarchy case rather than just using simple bridge routing. Acked-by: Jesse Barnes <jbarnes at virtuousgeek.org> -- Jesse Barnes, Intel Open Source Technology Center