> -----Original Message----- > From: Julien Panis <jpa...@baylibre.com> > Sent: Thursday, March 28, 2024 2:57 PM > To: David S. Miller <da...@davemloft.net>; Eric Dumazet > <eduma...@google.com>; Jakub Kicinski <k...@kernel.org>; Paolo Abeni > <pab...@redhat.com>; Russell King <li...@armlinux.org.uk>; Alexei Starovoitov > <a...@kernel.org>; Daniel Borkmann <dan...@iogearbox.net>; Jesper Dangaard > Brouer <h...@kernel.org>; John Fastabend <john.fastab...@gmail.com>; > Sumit Semwal <sumit.sem...@linaro.org>; Christian König > <christian.koe...@amd.com>; Simon Horman <ho...@kernel.org>; Andrew > Lunn <and...@lunn.ch>; Ratheesh Kannoth <rkann...@marvell.com> > Cc: net...@vger.kernel.org; linux-ker...@vger.kernel.org; > b...@vger.kernel.org; > linux-me...@vger.kernel.org; dri-devel@lists.freedesktop.org; linaro-mm- > s...@lists.linaro.org; Julien Panis <jpa...@baylibre.com> > Subject: [PATCH net-next v5 1/3] net: ethernet: ti: Add accessors > for struct k3_cppi_desc_pool members > > This patch adds accessors for desc_size and cpumem members. They may be > used, for instance, to compute a descriptor index. > > Signed-off-by: Julien Panis <jpa...@baylibre.com> > --- > drivers/net/ethernet/ti/k3-cppi-desc-pool.c | 12 ++++++++++++ > drivers/net/ethernet/ti/k3-cppi-desc-pool.h | 2 ++ > 2 files changed, 14 insertions(+) > > diff --git a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c > b/drivers/net/ethernet/ti/k3- > cppi-desc-pool.c > index 05cc7aab1ec8..fe8203c05731 100644 > --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.c > +++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.c > @@ -132,5 +132,17 @@ size_t k3_cppi_desc_pool_avail(struct > k3_cppi_desc_pool *pool) } EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_avail); > > +size_t k3_cppi_desc_pool_desc_size(struct k3_cppi_desc_pool *pool) { > + return pool->desc_size;
Don't you need to add NULL check on pool ptr since this function is exported? > +} > +EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_desc_size); > + > +void *k3_cppi_desc_pool_cpuaddr(struct k3_cppi_desc_pool *pool) { > + return pool->cpumem; Same here. > +} > +EXPORT_SYMBOL_GPL(k3_cppi_desc_pool_cpuaddr); > + > MODULE_LICENSE("GPL"); > MODULE_DESCRIPTION("TI K3 CPPI5 descriptors pool API"); diff --git > a/drivers/net/ethernet/ti/k3-cppi-desc-pool.h > b/drivers/net/ethernet/ti/k3-cppi-desc- > pool.h > index a7e3fa5e7b62..149d5579a5e2 100644 > --- a/drivers/net/ethernet/ti/k3-cppi-desc-pool.h > +++ b/drivers/net/ethernet/ti/k3-cppi-desc-pool.h > @@ -26,5 +26,7 @@ k3_cppi_desc_pool_dma2virt(struct k3_cppi_desc_pool > *pool, dma_addr_t dma); void *k3_cppi_desc_pool_alloc(struct > k3_cppi_desc_pool *pool); void k3_cppi_desc_pool_free(struct > k3_cppi_desc_pool *pool, void *addr); size_t k3_cppi_desc_pool_avail(struct > k3_cppi_desc_pool *pool); > +size_t k3_cppi_desc_pool_desc_size(struct k3_cppi_desc_pool *pool); > +void *k3_cppi_desc_pool_cpuaddr(struct k3_cppi_desc_pool *pool); > > #endif /* K3_CPPI_DESC_POOL_H_ */ > > -- > 2.37.3 >