Re: [PATCH 1/9] fbdev: shmobile: fix snprintf truncation

[Helge Deller]

On 3/26/24 23:38, Arnd Bergmann wrote:

From: Arnd Bergmann <a...@arndb.de>

The name of the overlay does not fit into the fixed-length field:

drivers/video/fbdev/sh_mobile_lcdcfb.c:1577:2: error: 'snprintf' will always be 
truncated; specified size is 16, but format string expands to at least 25

Make it short enough by changing the string.

Fixes: c5deac3c9b22 ("fbdev: sh_mobile_lcdc: Implement overlays support")
Signed-off-by: Arnd Bergmann <a...@arndb.de>

applied to fbdev git tree.

Thanks!
Helge

---
  drivers/video/fbdev/sh_mobile_lcdcfb.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/sh_mobile_lcdcfb.c 
b/drivers/video/fbdev/sh_mobile_lcdcfb.c
index eb2297b37504..d35d2cf99998 100644
--- a/drivers/video/fbdev/sh_mobile_lcdcfb.c
+++ b/drivers/video/fbdev/sh_mobile_lcdcfb.c
@@ -1575,7 +1575,7 @@ sh_mobile_lcdc_overlay_fb_init(struct 
sh_mobile_lcdc_overlay *ovl)
         */
        info->fix = sh_mobile_lcdc_overlay_fix;
        snprintf(info->fix.id, sizeof(info->fix.id),
-                "SH Mobile LCDC Overlay %u", ovl->index);
+                "SHMobile ovl %u", ovl->index);
        info->fix.smem_start = ovl->dma_handle;
        info->fix.smem_len = ovl->fb_size;
        info->fix.line_length = ovl->pitch;