The "num_levels" variable is used to store error codes from
device_property_count_u32() so it needs to be signed.  This doesn't
cause an issue at runtime because devm_kcalloc() won't allocate negative
sizes.  However, it's still worth fixing.

Fixes: b54c828bdba9 ("backlight: mp3309c: Make use of device properties")
Signed-off-by: Dan Carpenter <dan.carpen...@linaro.org>
---
 drivers/video/backlight/mp3309c.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/video/backlight/mp3309c.c 
b/drivers/video/backlight/mp3309c.c
index c80a1481e742..4e98e60417d2 100644
--- a/drivers/video/backlight/mp3309c.c
+++ b/drivers/video/backlight/mp3309c.c
@@ -205,8 +205,9 @@ static int mp3309c_parse_fwnode(struct mp3309c_chip *chip,
                                struct mp3309c_platform_data *pdata)
 {
        int ret, i;
-       unsigned int num_levels, tmp_value;
+       unsigned int tmp_value;
        struct device *dev = chip->dev;
+       int num_levels;
 
        if (!dev_fwnode(dev))
                return dev_err_probe(dev, -ENODEV, "failed to get firmware 
node\n");
-- 
2.43.0

Reply via email to