Re: [PATCH v16 9/9] drm/i915/display: Read/Write Adaptive Sync SDP

[Nautiyal, Ankit K]

On 3/7/2024 11:23 AM, Mitul Golani wrote:
Add read/write calls for Adaptive Sync SDP.

Signed-off-by: Mitul Golani <mitulkumar.ajitkumar.gol...@intel.com>
---
  drivers/gpu/drm/i915/display/intel_ddi.c | 1 +
  drivers/gpu/drm/i915/display/intel_dp.c  | 1 +
  2 files changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c 
b/drivers/gpu/drm/i915/display/intel_ddi.c
index c587a8efeafc..f164020a4773 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3972,6 +3972,7 @@ static void intel_ddi_get_config(struct intel_encoder 
*encoder,
  
  	intel_read_dp_sdp(encoder, pipe_config, HDMI_PACKET_TYPE_GAMUT_METADATA);
        intel_read_dp_sdp(encoder, pipe_config, DP_SDP_VSC);
+       intel_read_dp_sdp(encoder, pipe_config, DP_SDP_ADAPTIVE_SYNC);
  
  	intel_audio_codec_get_config(encoder, pipe_config);
  }
diff --git a/drivers/gpu/drm/i915/display/intel_dp.c 
b/drivers/gpu/drm/i915/display/intel_dp.c
index cf89e69d2e7a..7f87876651e7 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -4330,6 +4330,7 @@ void intel_dp_set_infoframes(struct intel_encoder 
*encoder,
                return;
  
  	intel_write_dp_sdp(encoder, crtc_state, DP_SDP_VSC);
+       intel_write_dp_sdp(encoder, crtc_state, DP_SDP_ADAPTIVE_SYNC);
  


Though not related to this patch, but IMHO we can remove extra space 
between consecutive intel_write_dp_sdp.

In any case, patch looks good to me.

Reviewed-by: Ankit Nautiyal <ankit.k.nauti...@intel.com>

        intel_write_dp_sdp(encoder, crtc_state, 
HDMI_PACKET_TYPE_GAMUT_METADATA);
  }