Don't pollute dmesg on deferred probe and simplify the code with
dev_err_probe().

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>
---
 drivers/video/backlight/bd6107.c | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/drivers/video/backlight/bd6107.c b/drivers/video/backlight/bd6107.c
index c95a12bf0ce2..b1e7126380ef 100644
--- a/drivers/video/backlight/bd6107.c
+++ b/drivers/video/backlight/bd6107.c
@@ -119,7 +119,6 @@ static int bd6107_probe(struct i2c_client *client)
        struct backlight_device *backlight;
        struct backlight_properties props;
        struct bd6107 *bd;
-       int ret;
 
        if (pdata == NULL) {
                dev_err(&client->dev, "No platform data\n");
@@ -147,11 +146,9 @@ static int bd6107_probe(struct i2c_client *client)
         * the reset.
         */
        bd->reset = devm_gpiod_get(&client->dev, "reset", GPIOD_OUT_HIGH);
-       if (IS_ERR(bd->reset)) {
-               dev_err(&client->dev, "unable to request reset GPIO\n");
-               ret = PTR_ERR(bd->reset);
-               return ret;
-       }
+       if (IS_ERR(bd->reset))
+               return dev_err_probe(&client->dev, PTR_ERR(bd->reset),
+                                    "unable to request reset GPIO\n");
 
        memset(&props, 0, sizeof(props));
        props.type = BACKLIGHT_RAW;

-- 
2.34.1

Reply via email to