Re: [PATCH] drm/mxsfb: Switch to drmm_mode_config_init

[Thomas Zimmermann]

Hi

Am 25.11.23 um 23:25 schrieb Marek Vasut:

Switch from deprecated unmanaged drm_mode_config_init() to
managed drmm_mode_config_init(). No functional change.

Signed-off-by: Marek Vasut <ma...@denx.de>
---
Cc: Daniel Vetter <dan...@ffwll.ch>
Cc: David Airlie <airl...@gmail.com>
Cc: Fabio Estevam <feste...@gmail.com>
Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
Cc: Maxime Ripard <mrip...@kernel.org>
Cc: NXP Linux Team <linux-...@nxp.com>
Cc: Pengutronix Kernel Team <ker...@pengutronix.de>
Cc: Sascha Hauer <s.ha...@pengutronix.de>
Cc: Shawn Guo <shawn...@kernel.org>
Cc: Stefan Agner <ste...@agner.ch>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: dri-devel@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
---
  drivers/gpu/drm/mxsfb/mxsfb_drv.c | 6 +++++-
  1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_drv.c 
b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
index 3bfa369b2507e..9f746852b8ff2 100644
--- a/drivers/gpu/drm/mxsfb/mxsfb_drv.c
+++ b/drivers/gpu/drm/mxsfb/mxsfb_drv.c
@@ -248,7 +248,11 @@ static int mxsfb_load(struct drm_device *drm,
        pm_runtime_enable(drm->dev);

-       drm_mode_config_init(drm);

/* Modeset init */

Best regards
Thomas

The corresponding call to drm_mode_config_cleanup() needs to be removed as well.

+       ret = drmm_mode_config_init(drm);
+       if (ret) {
+               dev_err(drm->dev, "Failed to initialize mode config\n");
+               goto err_vblank;
+       }

        if (ret < 0) {

ret = mxsfb_kms_init(mxsfb);

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

OpenPGP_signature.asc
Description: OpenPGP digital signature