Re: [PATCH v1] drm/tiny: correctly print `struct resource *` on error

[Thomas Zimmermann]

Hi

Am 10.10.23 um 19:46 schrieb Joey Gouly:

The `res` variable is already a `struct resource *`, don't take the address of 
it.

Fixes incorrect output:

        simple-framebuffer 9e20dc000.framebuffer: [drm] *ERROR* could not 
acquire memory range [??? 0xffff4be88a387d00-0xfffffefffde0a240 flags 0x0]: -16

To be correct:

        simple-framebuffer 9e20dc000.framebuffer: [drm] *ERROR* could not 
acquire memory range [mem 0x9e20dc000-0x9e307bfff flags 0x200]: -16

Signed-off-by: Joey Gouly <joey.go...@arm.com>
Cc: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Javier Martinez Canillas <javi...@redhat.com>

Cc: Thierry Reding <tred...@nvidia.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <sta...@vger.kernel.org> # v6.3+

Best regards
Thomas

It's a bug fix. I'm going to merge this patch into drm-misc-fixes with the following additional tags: Fixes: 9a10c7e6519b ("drm/simpledrm: Add support for system memory framebuffers")

---
  drivers/gpu/drm/tiny/simpledrm.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/tiny/simpledrm.c b/drivers/gpu/drm/tiny/simpledrm.c
index ff86ba1ae1b8..8ea120eb8674 100644
--- a/drivers/gpu/drm/tiny/simpledrm.c
+++ b/drivers/gpu/drm/tiny/simpledrm.c
@@ -745,7 +745,7 @@ static struct simpledrm_device 
*simpledrm_device_create(struct drm_driver *drv,

                if (ret) {
-                       drm_err(dev, "could not acquire memory range %pr: %d\n", 
&res, ret);
+                       drm_err(dev, "could not acquire memory range %pr: 
%d\n", res, ret);
                        return ERR_PTR(ret);
                }

ret = devm_aperture_acquire_from_firmware(dev, res->start, resource_size(res));

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

OpenPGP_signature.asc
Description: OpenPGP digital signature