Re: [PATCH v6 1/4] drm/i915: Introduce intel_gt_mcr_lock_reset()

[Nirmoy Das]

On 9/28/2023 9:18 AM, Andi Shyti wrote:

Hi Nirmoy,

your client is still missing my e-mails? :)

I did reply with a question!

+void intel_gt_mcr_lock_reset(struct intel_gt *gt)
+{
+       unsigned long __flags;
+
+       lockdep_assert_not_held(&gt->uncore->lock);
+
+       spin_lock_irqsave(&gt->mcr_lock, __flags);
+
+       if (GRAPHICS_VER_FULL(gt->i915) >= IP_VER(12, 70))
+               intel_uncore_write_fw(gt->uncore, MTL_STEER_SEMAPHORE, 0x1);
+
+       spin_unlock_irqrestore(&gt->mcr_lock, __flags);

I commented here that probably we don't need the locks. And I
asked you whether you had any reason for locking here.

I asked the question back to you and I send this before you could reply.

Will remove the lock.


Thanks,

Nirmoy

Andi

+}