On Thu, Oct 10, 2013 at 10:50 AM, Rafał Miłecki <zaj...@gmail.com> wrote:
> 2013/10/10 Alex Deucher <alexdeuc...@gmail.com>:
>> On Thu, Oct 10, 2013 at 1:39 AM, Rafał Miłecki <zaj...@gmail.com> wrote:
>>> 2013/10/10 Alex Deucher <alexdeuc...@gmail.com>:
>>>>       drm/radeon: use hw generated CTS/N values for audio
>>>
>>> I'd like to see such patches earlier :| I'm OK with the change for
>>> DCE4+ (Evergreen) (I even suggested that change myself recently), but
>>> I didn't have time to check how this should be programmed on
>>> DCE2/3/4...
>>>
>>> In your patch 0001-WIP-port-of-hdmi-dp-audio-code-to-newer-kernel.patch
>>> based on (AFAIU) internal specs you were setting HDMI_ACR_SOURCE.
>>>
>>> According to the Christian R6xx may really have some bug for
>>> generating values by the hw, see:
>>> https://bugs.freedesktop.org/show_bug.cgi?id=69675#c12
>>>
>>> So it doesn't look like a good patch for -fixes, especially without
>>> testing it on some hardware.
>>
>> Yeah, I thought about that, but on the other hand, there is already a
>> regression caused by the 1001 modes patches that this series fixes.  I
>> can add a patch to disable the hw generated values on older families
>> for now if you'd prefer.
>
> It would be nice. I'm working on getting some old GPUs, tracing fglrx
> and testing. So I hope to get HDMI support on DCE2/3 cleaned soon.
Attached.  I'll send an updated pull request with the patch added.

Alex

Attachment: 0001-drm-radeon-re-enable-sw-ACR-support-on-pre-DCE4.patch
Description: Binary data

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

Reply via email to