Hi Siddh,

Thank you for the patch.

On Sun, Aug 20, 2023 at 05:10:39PM +0530, Siddh Raman Pant wrote:
> drm_print.h says DRM_INFO is deprecated in favor of drm_info().
> 
> Signed-off-by: Siddh Raman Pant <c...@siddh.me>

Reviewed-by: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>

> ---
>  drivers/gpu/drm/drm_client_modeset.c | 2 +-
>  drivers/gpu/drm/drm_connector.c      | 7 ++++---
>  drivers/gpu/drm/drm_drv.c            | 2 +-
>  drivers/gpu/drm/drm_pci.c            | 2 +-
>  4 files changed, 7 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_client_modeset.c 
> b/drivers/gpu/drm/drm_client_modeset.c
> index 1b12a3c201a3..ae19734974b5 100644
> --- a/drivers/gpu/drm/drm_client_modeset.c
> +++ b/drivers/gpu/drm/drm_client_modeset.c
> @@ -331,7 +331,7 @@ static bool drm_client_target_cloned(struct drm_device 
> *dev,
>               DRM_DEBUG_KMS("can clone using 1024x768\n");
>               return true;
>       }
> -     DRM_INFO("kms: can't enable cloning when we probably wanted to.\n");
> +     drm_info(dev, "kms: can't enable cloning when we probably wanted 
> to.\n");
>       return false;
>  }
>  
> diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
> index bf8371dc2a61..1145d9e64c24 100644
> --- a/drivers/gpu/drm/drm_connector.c
> +++ b/drivers/gpu/drm/drm_connector.c
> @@ -168,13 +168,14 @@ static void drm_connector_get_cmdline_mode(struct 
> drm_connector *connector)
>               return;
>  
>       if (mode->force) {
> -             DRM_INFO("forcing %s connector %s\n", connector->name,
> -                      drm_get_connector_force_name(mode->force));
> +             drm_info(connector->dev, "forcing %s connector %s\n",
> +                      connector->name, 
> drm_get_connector_force_name(mode->force));
>               connector->force = mode->force;
>       }
>  
>       if (mode->panel_orientation != DRM_MODE_PANEL_ORIENTATION_UNKNOWN) {
> -             DRM_INFO("cmdline forces connector %s panel_orientation to 
> %d\n",
> +             drm_info(connector->dev,
> +                      "cmdline forces connector %s panel_orientation to 
> %d\n",
>                        connector->name, mode->panel_orientation);
>               drm_connector_set_panel_orientation(connector,
>                                                   mode->panel_orientation);
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 3eda026ffac6..d457f2053c05 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -943,7 +943,7 @@ int drm_dev_register(struct drm_device *dev, unsigned 
> long flags)
>       if (drm_core_check_feature(dev, DRIVER_MODESET))
>               drm_modeset_register_all(dev);
>  
> -     DRM_INFO("Initialized %s %d.%d.%d %s for %s on minor %d\n",
> +     drm_info(dev, "Initialized %s %d.%d.%d %s for %s on minor %d\n",
>                driver->name, driver->major, driver->minor,
>                driver->patchlevel, driver->date,
>                dev->dev ? dev_name(dev->dev) : "virtual device",
> diff --git a/drivers/gpu/drm/drm_pci.c b/drivers/gpu/drm/drm_pci.c
> index 39d35fc3a43b..7dfb837d1325 100644
> --- a/drivers/gpu/drm/drm_pci.c
> +++ b/drivers/gpu/drm/drm_pci.c
> @@ -262,7 +262,7 @@ void drm_legacy_pci_exit(const struct drm_driver *driver,
>               }
>               mutex_unlock(&legacy_dev_list_lock);
>       }
> -     DRM_INFO("Module unloaded\n");
> +     drm_info(NULL, "Module unloaded\n");
>  }
>  EXPORT_SYMBOL(drm_legacy_pci_exit);
>  

-- 
Regards,

Laurent Pinchart

Reply via email to