On Tue, 01 Aug 2023 18:10:25 +0800, Keith Zhao wrote:
> StarFive SoCs JH7110 display system:
> lcd-controller bases verisilicon dc8200 IP,
> and hdmi bases Innosilicon IP.
> Add bindings for them.
> 
> Signed-off-by: Keith Zhao <keith.z...@starfivetech.com>
> ---
>  .../starfive/starfive,display-subsystem.yaml  |  41 +++++++
>  .../starfive/starfive,jh7110-dc8200.yaml      | 107 ++++++++++++++++++
>  .../starfive/starfive,jh7110-inno-hdmi.yaml   |  92 +++++++++++++++
>  3 files changed, 240 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/starfive/starfive,jh7110-dc8200.yaml
>  create mode 100644 
> Documentation/devicetree/bindings/display/starfive/starfive,jh7110-inno-hdmi.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.example.dtb:
 display-subsystem: ports: [[4294967295]] is not of type 'object'
        from schema $id: 
http://devicetree.org/schemas/display/starfive/starfive,display-subsystem.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/display/starfive/starfive,display-subsystem.example.dtb:
 display-subsystem: ports: More than one condition true in oneOf schema:
        {'additionalProperties': False,
         'oneOf': [{'required': ['port']},
                   {'required': ['#address-cells', '#size-cells']}],
         'patternProperties': {'^port@[0-9a-f]+$': {'required': ['reg'],
                                                    'type': 'object'},
                               'pinctrl-[0-9]+': True},
         'properties': {'#address-cells': {'items': [{'items': [{'const': 1}],
                                                      'maxItems': 1,
                                                      'minItems': 1,
                                                      'type': 'array'}],
                                           'maxItems': 1,
                                           'minItems': 1,
                                           'type': 'array'},
                        '#size-cells': {'items': [{'items': [{'const': 0}],
                                                   'maxItems': 1,
                                                   'minItems': 1,
                                                   'type': 'array'}],
                                        'maxItems': 1,
                                        'minItems': 1,
                                        'type': 'array'},
                        '$nodename': True,
                        'bootph-all': True,
                        'bootph-pre-ram': True,
                        'bootph-pre-sram': True,
                        'bootph-some-ram': True,
                        'bootph-verify': True,
                        'phandle': True,
                        'pinctrl-names': True,
                        'port': {'type': 'object'},
                        'secure-status': True,
                        'status': True},
         'type': 'object'}
        from schema $id: 
http://devicetree.org/schemas/display/starfive/starfive,display-subsystem.yaml#

doc reference errors (make refcheckdocs):

See 
https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230801101030.2040-3-keith.z...@starfivetech.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Reply via email to