Re: [PATCH 1/3] drm/drv: use enum drm_minor_type when appropriate

[James Zhu]

Hi Simon

Thanks!

Reviewed-by:JamesZhu<james....@amd.com>fortheseries.Best Regards! James Zhu

On 2023-07-14 06:46, Simon Ser wrote:

This makes it easier to figure out what the "type" variable can be
set to when reading the implementation of these functions.

Signed-off-by: Simon Ser<cont...@emersion.fr>
Cc: Christian König<christian.koe...@amd.com>
Cc: James Zhu<james....@amd.com>
Cc: Marek Olšák<marek.ol...@amd.com>
Cc: Daniel Vetter<daniel.vet...@ffwll.ch>
---
  drivers/gpu/drm/drm_drv.c | 8 ++++----
  1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 12687dd9e1ac..3eda026ffac6 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -84,7 +84,7 @@ DEFINE_STATIC_SRCU(drm_unplug_srcu);
   */

static struct drm_minor **drm_minor_get_slot(struct drm_device *dev,

-                                            unsigned int type)
+                                            enum drm_minor_type type)
  {
        switch (type) {
        case DRM_MINOR_PRIMARY:
@@ -116,7 +116,7 @@ static void drm_minor_alloc_release(struct drm_device *dev, 
void *data)
        }
  }

-static int drm_minor_alloc(struct drm_device *dev, unsigned int type)

+static int drm_minor_alloc(struct drm_device *dev, enum drm_minor_type type)
  {
        struct drm_minor *minor;
        unsigned long flags;
@@ -160,7 +160,7 @@ static int drm_minor_alloc(struct drm_device *dev, unsigned 
int type)
        return 0;
  }

-static int drm_minor_register(struct drm_device *dev, unsigned int type)

+static int drm_minor_register(struct drm_device *dev, enum drm_minor_type type)
  {
        struct drm_minor *minor;
        unsigned long flags;
@@ -203,7 +203,7 @@ static int drm_minor_register(struct drm_device *dev, 
unsigned int type)
        return ret;
  }

-static void drm_minor_unregister(struct drm_device *dev, unsigned int type)

+static void drm_minor_unregister(struct drm_device *dev, enum drm_minor_type 
type)
  {
        struct drm_minor *minor;
        unsigned long flags;