Re: [PATCH 8/8] drm/msm/dpu: remove unused fields from struct dpu_core_perf

[Abhinav Kumar]

On 6/19/2023 5:08 PM, Dmitry Baryshkov wrote:

Remove dpu_core_perf::dev and dpu_core_perf::debugfs_root fields, they
are not used by the code.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c | 2 --
  drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h | 4 ----
  drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c       | 2 +-
  3 files changed, 1 insertion(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c 
b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
index f779ad544347..7f110d15b101 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c
@@ -395,11 +395,9 @@ int dpu_core_perf_debugfs_init(struct dpu_kms *dpu_kms, 
struct dentry *parent)
  #endif

int dpu_core_perf_init(struct dpu_core_perf *perf,

-               struct drm_device *dev,
                const struct dpu_perf_cfg *perf_cfg,
                struct clk *core_clk)
  {
-       perf->dev = dev;
        perf->perf_cfg = perf_cfg;
        perf->core_clk = core_clk;

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h

index e1198c104b5e..623e2d058695 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.h
@@ -27,7 +27,6 @@ struct dpu_core_perf_params {
  /**
   * struct dpu_core_perf - definition of core performance context
   * @dev: Pointer to drm device

remove dev from here too

- * @debugfs_root: top level debug folder
   * @perf_cfg: Platform-specific performance configuration
   * @core_clk: Pointer to the core clock
   * @core_clk_rate: current core clock rate
@@ -36,8 +35,6 @@ struct dpu_core_perf_params {
   * @enable_bw_release: debug control for bandwidth release
   */
  struct dpu_core_perf {
-       struct drm_device *dev;
-       struct dentry *debugfs_root;
        const struct dpu_perf_cfg *perf_cfg;
        struct clk *core_clk;
        u64 core_clk_rate;
@@ -77,7 +74,6 @@ void dpu_core_perf_crtc_release_bw(struct drm_crtc *crtc);
   * @core_clk: pointer to core clock
   */
  int dpu_core_perf_init(struct dpu_core_perf *perf,
-               struct drm_device *dev,
                const struct dpu_perf_cfg *perf_cfg,
                struct clk *core_clk);

diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c

index 4439147d2c35..5297cec68c9c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -1115,7 +1115,7 @@ static int dpu_kms_hw_init(struct msm_kms *kms)
                dpu_kms->hw_vbif[vbif->id] = hw;
        }

- rc = dpu_core_perf_init(&dpu_kms->perf, dev, dpu_kms->catalog->perf,

+       rc = dpu_core_perf_init(&dpu_kms->perf, dpu_kms->catalog->perf,
                        msm_clk_bulk_get_clock(dpu_kms->clocks, dpu_kms->num_clocks, 
"core"));
        if (rc) {
                DPU_ERROR("failed to init perf %d\n", rc);