From: Sui Jingfeng <suijingf...@loongson.cn>

Because getting IRQ from a device is platform-dependent, PCI devices have
different methods for getting an IRQ. This patch is a preparation to extend
this driver for supporting the PCI devices.

Cc: Lucas Stach <l.st...@pengutronix.de>
Cc: Christian Gmeiner <christian.gmei...@gmail.com>
Cc: Philipp Zabel <p.za...@pengutronix.de>
Cc: Bjorn Helgaas <bhelg...@google.com>
Cc: Daniel Vetter <dan...@ffwll.ch>
Signed-off-by: Sui Jingfeng <suijingf...@loongson.cn>
---
 drivers/gpu/drm/etnaviv/etnaviv_gpu.c | 32 +++++++++++++++++++--------
 1 file changed, 23 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c 
b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
index de8c9894967c..a03e81337d8f 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gpu.c
@@ -1817,6 +1817,27 @@ static const struct of_device_id etnaviv_gpu_match[] = {
 };
 MODULE_DEVICE_TABLE(of, etnaviv_gpu_match);
 
+static int etnaviv_gpu_register_irq(struct etnaviv_gpu *gpu, int irq)
+{
+       struct device *dev = gpu->dev;
+       int err;
+
+       if (irq < 0)
+               return irq;
+
+       err = devm_request_irq(dev, irq, irq_handler, 0, dev_name(dev), gpu);
+       if (err) {
+               dev_err(dev, "failed to request irq %u: %d\n", irq, err);
+               return err;
+       }
+
+       gpu->irq = irq;
+
+       dev_info(dev, "irq(%d) handler registered\n", irq);
+
+       return 0;
+}
+
 static int etnaviv_gpu_platform_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
@@ -1837,16 +1858,9 @@ static int etnaviv_gpu_platform_probe(struct 
platform_device *pdev)
                return PTR_ERR(gpu->mmio);
 
        /* Get Interrupt: */
-       gpu->irq = platform_get_irq(pdev, 0);
-       if (gpu->irq < 0)
-               return gpu->irq;
-
-       err = devm_request_irq(&pdev->dev, gpu->irq, irq_handler, 0,
-                              dev_name(gpu->dev), gpu);
-       if (err) {
-               dev_err(dev, "failed to request IRQ%u: %d\n", gpu->irq, err);
+       err = etnaviv_gpu_register_irq(gpu, platform_get_irq(pdev, 0));
+       if (err)
                return err;
-       }
 
        /* Get Clocks: */
        gpu->clk_reg = devm_clk_get_optional(&pdev->dev, "reg");
-- 
2.25.1

Reply via email to