Re: [PATCH] drm/drm_gem.c: remove surplus else after return clause

[Sui Jingfeng]

ping ?

On 2023/3/14 20:53, Sui Jingfeng wrote:

  else is not generally useful after return

Signed-off-by: Sui Jingfeng <15330273...@189.cn>
---
  drivers/gpu/drm/drm_gem.c | 7 ++++---
  1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/drm/drm_gem.c
index a6208e2c089b..364e3733af98 100644
--- a/drivers/gpu/drm/drm_gem.c
+++ b/drivers/gpu/drm/drm_gem.c
@@ -1150,8 +1150,8 @@ int drm_gem_pin(struct drm_gem_object *obj)
  {
        if (obj->funcs->pin)
                return obj->funcs->pin(obj);
-       else
-               return 0;
+
+       return 0;
  }

void drm_gem_unpin(struct drm_gem_object *obj)

@@ -1172,7 +1172,8 @@ int drm_gem_vmap(struct drm_gem_object *obj, struct 
iosys_map *map)
        ret = obj->funcs->vmap(obj, map);
        if (ret)
                return ret;
-       else if (iosys_map_is_null(map))
+
+       if (iosys_map_is_null(map))
                return -ENOMEM;

return 0;

--
Jingfeng