Re: [PATCH v2 01/38] backlight/bd6107: Compare against struct fb_info.device

[Thomas Zimmermann]

Hi

Am 13.06.23 um 12:37 schrieb Daniel Thompson:

On Mon, Jun 12, 2023 at 04:07:39PM +0200, Thomas Zimmermann wrote:

Struct bd6107_platform_data refers to a platform device within
the Linux device hierarchy. The test in bd6107_backlight_check_fb()
compares it against the fbdev device in struct fb_info.dev, which
is different. Fix the test by comparing to struct fb_info.device.

Fixes a bug in the backlight driver and prepares fbdev for making
struct fb_info.dev optional.

v2:
        * move renames into separate patch (Javier, Sam, Michael)

Fixes: 67b43e590415 ("backlight: Add ROHM BD6107 backlight driver")
Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
Cc: Laurent Pinchart <laurent.pinchart+rene...@ideasonboard.com>
Cc: Lee Jones <l...@kernel.org>
Cc: Daniel Thompson <daniel.thomp...@linaro.org>
Cc: Jingoo Han <jingooh...@gmail.com>
Cc: dri-devel@lists.freedesktop.org
Cc: <sta...@vger.kernel.org> # v3.12+
Reviewed-by: Javier Martinez Canillas <javi...@redhat.com>

Reviewed-by: Daniel Thompson <daniel.thomp...@linaro.org>

Thanks for going through the backlight patches.

Daniel.

PS Please don't treat this as an Acked-by, if you want to land this
    patchset via a single tree please coordinate with Lee Jones!

Best regards
Thomas

--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)

I'd like to merge them via drm-misc-next together with the rest of the patchset. It's not DRM, but fbdev patches often go through that tree quite often.

OpenPGP_signature
Description: OpenPGP digital signature