Re: [PATCH 4/7] drm/msm/dpu: drop duplicated intf/wb indices from encoder structs

[Abhinav Kumar]

On 4/30/2023 4:57 PM, Dmitry Baryshkov wrote:
Remove intf_idx and wb_idx fields from struct dpu_encoder_phys and
struct dpu_enc_phys_init_params. Set the hw_intf and hw_wb directly and
use them to get the instance index.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---

From whatever I can see, this will not affect functionality of intf or 
wb and cleans it up well , so I am fine with this. Hence,

Reviewed-by: Abhinav Kumar <quic_abhin...@quicinc.com>

One minor comment/question.

<snipped other parts>

@@ -761,7 +761,7 @@ struct dpu_encoder_phys *dpu_encoder_phys_cmd_init(
        struct dpu_encoder_phys_cmd *cmd_enc = NULL;
        int ret = 0;
  
-	DPU_DEBUG("intf %d\n", p->intf_idx - INTF_0);

Was it intentional to drop the index in this log?

+       DPU_DEBUG("intf\n");
  
  	cmd_enc = kzalloc(sizeof(*cmd_enc), GFP_KERNEL);