Re: [PATCH] drm/i915: Fix memory leaks in i915 selftests

[Andrzej Hajda]

On 13.04.2023 05:13, Cong Liu wrote:

Fixes: c3bfba9a2225 ("drm/i915: Check for integer truncation on scatterlist 
creation")

Signed-off-by: Cong Liu <liuco...@kylinos.cn>
---

Reviewed-by: Andrzej Hajda <andrzej.ha...@intel.com>

Regards
Andrzej

  drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +++-
  1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c 
b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
index 5361ce70d3f2..154801f1c468 100644
--- a/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
+++ b/drivers/gpu/drm/i915/selftests/i915_gem_gtt.c
@@ -69,8 +69,10 @@ static int fake_get_pages(struct drm_i915_gem_object *obj)

rem = round_up(obj->base.size, BIT(31)) >> 31;

        /* restricted by sg_alloc_table */
-       if (overflows_type(rem, unsigned int))
+       if (overflows_type(rem, unsigned int)) {
+               kfree(pages);
                return -E2BIG;
+       }

if (sg_alloc_table(pages, rem, GFP)) {

                kfree(pages);