Hi Rob, I love your patch! Yet something to improve:
[auto build test ERROR on drm-misc/drm-misc-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Rob-Herring/fbdev-Use-of_property_present-for-testing-DT-property-presence/20230310-225754 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230310144729.1545943-1-robh%40kernel.org patch subject: [PATCH] fbdev: Use of_property_present() for testing DT property presence config: arm64-randconfig-r032-20230310 (https://download.01.org/0day-ci/archive/20230311/202303111229.3uuc8jqv-...@intel.com/config) compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm64 cross compiling tool for clang build # apt-get install binutils-aarch64-linux-gnu # https://github.com/intel-lab-lkp/linux/commit/c013f4111f36b0b4327e7fbf46c0dd93399e9209 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Rob-Herring/fbdev-Use-of_property_present-for-testing-DT-property-presence/20230310-225754 git checkout c013f4111f36b0b4327e7fbf46c0dd93399e9209 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/video/fbdev/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> | Link: https://lore.kernel.org/oe-kbuild-all/202303111229.3uuc8jqv-...@intel.com/ All errors (new ones prefixed by >>): >> drivers/video/fbdev/amba-clcd.c:857:6: error: call to undeclared function >> 'of_property_present'; ISO C99 and later do not support implicit function >> declarations [-Wimplicit-function-declaration] if (of_property_present(node, "memory-region")) { ^ drivers/video/fbdev/amba-clcd.c:857:6: note: did you mean 'fwnode_property_present'? include/linux/property.h:59:6: note: 'fwnode_property_present' declared here bool fwnode_property_present(const struct fwnode_handle *fwnode, ^ 1 error generated. vim +/of_property_present +857 drivers/video/fbdev/amba-clcd.c 843 844 static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev) 845 { 846 struct clcd_board *board = devm_kzalloc(&dev->dev, sizeof(*board), 847 GFP_KERNEL); 848 struct device_node *node = dev->dev.of_node; 849 850 if (!board) 851 return NULL; 852 853 board->name = of_node_full_name(node); 854 board->caps = CLCD_CAP_ALL; 855 board->check = clcdfb_check; 856 board->decode = clcdfb_decode; > 857 if (of_property_present(node, "memory-region")) { 858 board->setup = clcdfb_of_vram_setup; 859 board->mmap = clcdfb_of_vram_mmap; 860 board->remove = clcdfb_of_vram_remove; 861 } else { 862 board->setup = clcdfb_of_dma_setup; 863 board->mmap = clcdfb_of_dma_mmap; 864 board->remove = clcdfb_of_dma_remove; 865 } 866 867 return board; 868 } 869 #else 870 static struct clcd_board *clcdfb_of_get_board(struct amba_device *dev) 871 { 872 return NULL; 873 } 874 #endif 875 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
