Hi Jonathan, Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-tip/drm-tip] [also build test WARNING on linus/master v6.2-rc5] [cannot apply to drm-misc/drm-misc-next drm/drm-next drm-exynos/exynos-drm-next drm-intel/for-linux-next drm-intel/for-linux-next-fixes] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jonathan-Kim/drm-amdkfd-add-debug-and-runtime-enable-interface/20230128-092952 base: git://anongit.freedesktop.org/drm/drm-tip drm-tip patch link: https://lore.kernel.org/r/20230125195401.4183544-7-jonathan.kim%40amd.com patch subject: [PATCH 06/32] drm/amdgpu: add gfx9 hw debug mode enable and disable calls config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20230129/202301291257.prqg0vpg-...@intel.com/config) compiler: gcc-11 (Debian 11.3.0-8) 11.3.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/11bb8b2034cd92b687a2d5461298cc72d720d5c9 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jonathan-Kim/drm-amdkfd-add-debug-and-runtime-enable-interface/20230128-092952 git checkout 11bb8b2034cd92b687a2d5461298cc72d720d5c9 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=x86_64 olddefconfig make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/gpu/drm/amd/amdgpu/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <l...@intel.com> All warnings (new ones prefixed by >>): >> drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:694: warning: This comment >> starts with '/**', but isn't a kernel-doc comment. Refer >> Documentation/doc-guide/kernel-doc.rst * restore_dbg_reisters is ignored here but is a general interface requirement drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c:718: warning: This comment starts with '/**', but isn't a kernel-doc comment. Refer Documentation/doc-guide/kernel-doc.rst * keep_trap_enabled is ignored here but is a general interface requirement vim +694 drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v9.c 692 693 /** > 694 * restore_dbg_reisters is ignored here but is a general interface > requirement 695 * for devices that support GFXOFF and where the RLC save/restore list 696 * does not support hw registers for debugging i.e. the driver has to manually 697 * initialize the debug mode registers after it has disabled GFX off during the 698 * debug session. 699 */ 700 uint32_t kgd_gfx_v9_enable_debug_trap(struct amdgpu_device *adev, 701 bool restore_dbg_registers, 702 uint32_t vmid) 703 { 704 mutex_lock(&adev->grbm_idx_mutex); 705 706 kgd_gfx_v9_set_wave_launch_stall(adev, vmid, true); 707 708 WREG32(SOC15_REG_OFFSET(GC, 0, mmSPI_GDBG_TRAP_MASK), 0); 709 710 kgd_gfx_v9_set_wave_launch_stall(adev, vmid, false); 711 712 mutex_unlock(&adev->grbm_idx_mutex); 713 714 return 0; 715 } 716 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests
