On 1/25/2023 2:14 AM, Marijn Suijten wrote:
Add missing DSC hardware block register ranges to the snapshot utility to include them in dmesg (on MSM_DISP_SNAPSHOT_DUMP_IN_CONSOLE) and the kms debugfs file. Signed-off-by: Marijn Suijten <marijn.suij...@somainline.org> Reviewed-by: Neil Armstrong <neil.armstr...@linaro.org>
Huge ack from me, Reviewed-by: Abhinav Kumar <quic_abhin...@quicinc.com>
--- Changes since v1: - Rebase on next-20230125 to solve conflicts with 43e3293fc614 ("drm/msm/dpu: add support for MDP_TOP blackhole"). v1: https://lore.kernel.org/linux-arm-msm/20230125091315.133283-1-marijn.suij...@somainline.org/T/#u drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c index d612419118a2..a683bd9b5a04 100644 --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c @@ -937,6 +937,11 @@ static void dpu_kms_mdp_snapshot(struct msm_disp_state *disp_state, struct msm_k dpu_kms->mmio + cat->mdp[0].base, "top"); }+ /* dump DSC sub-blocks HW regs info */+ for (i = 0; i < cat->dsc_count; i++) + msm_disp_snapshot_add_block(disp_state, cat->dsc[i].len, + dpu_kms->mmio + cat->dsc[i].base, "dsc_%d", i); + pm_runtime_put_sync(&dpu_kms->pdev->dev); }
