Hi Sachin, > -----Original Message----- > From: Sachin Kamat [mailto:sachin.ka...@linaro.org] > Sent: Friday, August 09, 2013 6:40 PM > To: Chanho Park > Cc: inki....@samsung.com; kgene....@samsung.com; dri- > de...@lists.freedesktop.org; kyungmin.p...@samsung.com; > mark.rutl...@arm.com; l.st...@pengutronix.de; s.nawro...@samsung.com; > tomasz.f...@gmail.com; linux-samsung-...@vger.kernel.org; linux-arm- > ker...@lists.infradead.org; devicet...@vger.kernel.org; Thomas Abraham > Subject: Re: [PATCHv2 5/5] ARM: dts: Add dt binding documentation for > exynos rotator > > Hi Chanho, > > On 9 August 2013 13:10, Chanho Park <chanho61.p...@samsung.com> wrote: > > This patch describes each nodes of rotator and specifies a example how > > to bind it. > > > > Signed-off-by: Chanho Park <chanho61.p...@samsung.com> > > Cc: Thomas Abraham <thomas.abra...@linaro.org> > > Cc: Kukjin Kim <kgene....@samsung.com> > > Cc: Inki Dae <inki....@samsung.com> > > Signed-off-by: Kyungmin Park <kyungmin.p...@samsung.com> > > --- > > .../devicetree/bindings/gpu/samsung-rotator.txt | 26 > ++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > create mode 100644 > > Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > > > diff --git a/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > new file mode 100644 > > index 0000000..31ee7b5 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/gpu/samsung-rotator.txt > > @@ -0,0 +1,26 @@ > > +* Samsung Image Rotator > > + > > +Required properties: > > + - compatible : value should be following: > > This should be "should be one of the following:"
I left out while I changed it to select multiple choices. Thanks. > > > + (a) "samsung,exynos4210-rotator" for Rotator IP in Exynos4210 > > + (b) "samsung,exynos4212-rotator" for Rotator IP in > Exynos4212/4412 > > + (c) "samsung,exynos5250-rotator" for Rotator IP in Exynos5250 > > + > > + - reg : Physical base address of the IP registers and length of > memory > > + mapped region. > > + > > + - interrupts : Interrupt number of Rotator > > + > > + - clocks : Clock number described in > Documentations/devicetree/binding/clock. > > The path has several typos. Instead you can simply mention clocks : from > common clock binding: handle to rotator clock. Oh, it has many typos. I'll change it. Thanks for your review. Best Regards, Chanho Park _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel
