On Thu, 2022-12-08 at 09:29 +0000, Tvrtko Ursulin wrote: > Just some small comments and questions below. > > On 08/12/2022 05:01, Alan Previn wrote: > > Starting with MTL, there will be two GT-tiles, a render and media > > Alan:[snip] > IMO this looks great now - pretty self-documenting, all the complicated > checks are contained to the init phase, and the comments are really good. > > Hopefully someone who knows the flows can cross-check this approach and > r-b, Daniele I suspect (copied)? From me its an ack. > > Acked-by: Tvrtko Ursulin <tvrtko.ursu...@intel.com> >
Alan: Thanks Tvrtko. As per offline email, i created an internal JIRA to track the other follow ups (intel_pxp_foo(pxp) -> intel_pxp_foo(i915) and inlines that could use CONFIG_I915_PXP - something that was there before but was removed for DG2 - perhaps could be added back in with accommodation on the internal functions). I will rev v12 to fix the comments and Daniele has agreed to review the changes from v9 (prior RB point).
