Hi Maxime,
On 11/16/22 06:17, Maxime Ripard wrote:
> The MODULE_LICENSE macro is missing from the kunit helpers file, thus
> leading to a build error.
>
> Let's introduce it along with MODULE_AUTHOR.
>
> Fixes: 44a3928324e9 ("drm/tests: Add Kunit Helpers")
> Reported-by: Stephen Rothwell <[email protected]>
> Signed-off-by: Maxime Ripard <[email protected]>
It would be nice to add the SPDX-License-Identifier tag in the source
file as well. Besides that,
Reviewed-by: Maíra Canal <[email protected]>
Best Regards,
- Maíra Canal
> ---
> drivers/gpu/drm/tests/drm_kunit_helpers.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> index dbd8ec24d4be..eea450de7de8 100644
> --- a/drivers/gpu/drm/tests/drm_kunit_helpers.c
> +++ b/drivers/gpu/drm/tests/drm_kunit_helpers.c
> @@ -64,3 +64,6 @@ struct drm_device *drm_kunit_device_init(struct kunit
> *test, u32 features, char
>
> return drm;
> }
> +
> +MODULE_AUTHOR("Maxime Ripard <[email protected]>");
> +MODULE_LICENSE("GPL");
