On Mon, Nov 7, 2022 at 6:25 PM Jeffrey Hugo <quic_jh...@quicinc.com> wrote: > > On 11/6/2022 2:02 PM, Oded Gabbay wrote: > > > @@ -603,6 +626,14 @@ static int drm_dev_init(struct drm_device *dev, > > /* no per-device feature limits by default */ > > dev->driver_features = ~0u; > > > > + if (drm_core_check_feature(dev, DRIVER_COMPUTE_ACCEL) && > > + (drm_core_check_feature(dev, DRIVER_RENDER) || > > + drm_core_check_feature(dev, DRIVER_MODESET))) > > { > > Shouldn't the indentation for the 2nd and 3rd line be such that the > start of the lines is aligned with the "(" on the first line? afaik there is no such rule. If there was, checkpatch should have reported that. Oded
- [RFC PATCH v3 0/3] new subsystem for compute accelerato... Oded Gabbay
- [RFC PATCH v3 1/3] drivers/accel: define kconfig a... Oded Gabbay
- Re: [RFC PATCH v3 1/3] drivers/accel: define k... Jeffrey Hugo
- Re: [RFC PATCH v3 1/3] drivers/accel: defi... Oded Gabbay
- Re: [RFC PATCH v3 1/3] drivers/accel: define k... Stanislaw Gruszka
- Re: [RFC PATCH v3 1/3] drivers/accel: defi... Oded Gabbay
- [RFC PATCH v3 3/3] drm: initialize accel framework Oded Gabbay
- Re: [RFC PATCH v3 3/3] drm: initialize accel f... Jeffrey Hugo
- Re: [RFC PATCH v3 3/3] drm: initialize acc... Oded Gabbay
- [RFC PATCH v3 2/3] accel: add dedicated minor for ... Oded Gabbay
- Re: [RFC PATCH v3 2/3] accel: add dedicated mi... Jeffrey Hugo
- Re: [RFC PATCH v3 2/3] accel: add dedicate... Oded Gabbay
- Re: [RFC PATCH v3 2/3] accel: add dedicated mi... Tvrtko Ursulin
- Re: [RFC PATCH v3 2/3] accel: add dedicate... Oded Gabbay
- Re: [RFC PATCH v3 0/3] new subsystem for compute a... Jeffrey Hugo
- Re: [RFC PATCH v3 0/3] new subsystem for compu... Matthew Wilcox
- Re: [RFC PATCH v3 0/3] new subsystem for compute a... Jason Gunthorpe
- Re: [RFC PATCH v3 0/3] new subsystem for compute a... Christopher Friedt