Re: [PATCH v1 5/5] arm64: dts: qcom: sm8450-hdk: Enable HDMI Display

[Krzysztof Kozlowski]

On 04/11/2022 09:13, Dmitry Baryshkov wrote:
> From: Vinod Koul <vk...@kernel.org>
> 
> Add the HDMI display nodes and link it to DSI. Also enable missing dispcc
> nodes
> 
> Signed-off-by: Vinod Koul <vk...@kernel.org>
> Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>

Thank you for your patch. There is something to discuss/improve.

> +&dispcc {
> +     status = "okay";
> +};
> +
>  &dsi0 {
>       status = "okay";
>       vdda-supply = <&vreg_l6b_1p2>;
> +
> +     ports {
> +             port@1 {
> +                     endpoint {
> +                             remote-endpoint = <&lt9611_a>;
> +                             data-lanes = <0 1 2 3>;
> +                     };
> +             };
> +     };
> +

Drop blank line.

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlow...@linaro.org>

Best regards,
Krzysztof