Re: [PATCH V2] drm: bridge/dw-hdmi-ahb-audio: use strscpy() is more robust and safer

[Neil Armstrong]

Hi,

On 20/09/2022 08:16, cgel....@gmail.com wrote:

From: Minghao Chi <chi.ming...@zte.com.cn>

The implementation of strscpy() is more robust and safer.

That's now the recommended way to copy NUL terminated strings.

Signed-off-by: Minghao Chi <chi.ming...@zte.com.cn>
---
v1->v2
using DRIVER_NAME instead of "DW-HDMI".
  drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c 
b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
index 7d2ed0ed2fe2..8cb6177f976d 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi-ahb-audio.c
@@ -542,8 +542,8 @@ static int snd_dw_hdmi_probe(struct platform_device *pdev)
        if (ret < 0)
                return ret;

- strlcpy(card->driver, DRIVER_NAME, sizeof(card->driver));

-       strlcpy(card->shortname, "DW-HDMI", sizeof(card->shortname));
+       strscpy(card->driver, DRIVER_NAME, sizeof(card->driver));
+       strscpy(card->shortname, DRIVER_NAME, sizeof(card->shortname));

OH, I did misread the first patch, and it was in fact ok... I'll apply v1 
instead !

Thanks for fixing, but sorry for my wrong review...

        snprintf(card->longname, sizeof(card->longname),
                 "%s rev 0x%02x, irq %d", card->shortname, revision,
                 data->irq);
@@ -561,7 +561,7 @@ static int snd_dw_hdmi_probe(struct platform_device *pdev)

dw->pcm = pcm;

        pcm->private_data = dw;
-       strlcpy(pcm->name, DRIVER_NAME, sizeof(pcm->name));
+       strscpy(pcm->name, DRIVER_NAME, sizeof(pcm->name));
        snd_pcm_set_ops(pcm, SNDRV_PCM_STREAM_PLAYBACK, &snd_dw_hdmi_ops);

/*

Neil