Re: [PATCH v3 5/9] drm/mediatek: Add gamma support different lut_bits for other SoC

[AngeloGioacchino Del Regno]

Il 11/09/22 17:37, Jason-JH.Lin ha scritto:

Add lut_bits in gamma driver data for each SoC and adjust the usage
of lut_bits in mtk_drm_gamma_set_common().

Signed-off-by: Jason-JH.Lin <jason-jh....@mediatek.com>
---
  drivers/gpu/drm/mediatek/mtk_disp_gamma.c | 36 ++++++++++++++++-------
  1 file changed, 25 insertions(+), 11 deletions(-)

diff --git a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c 
b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
index e69d0b205b9a..155fb5d94d79 100644
--- a/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
+++ b/drivers/gpu/drm/mediatek/mtk_disp_gamma.c
@@ -25,11 +25,14 @@

#define LUT_10BIT_MASK 0x03ff

  #define LUT_SIZE_DEFAULT                      512 /* for setting gamma lut 
from AAL */
+#define LUT_BITS_DEFAULT                       10
+#define LUT_INPUT_BITS                         16 /* input lut bit from 
application */

struct mtk_disp_gamma_data {

        bool has_dither;
        bool lut_diff;
        u16 lut_size;
+       u8 lut_bits;
  };

/*

@@ -72,17 +75,23 @@ void mtk_gamma_set_common(struct device *dev, void __iomem 
*regs, struct drm_crt
        struct mtk_disp_gamma *gamma = dev_get_drvdata(dev);
        bool lut_diff = false;
        u16 lut_size = LUT_SIZE_DEFAULT;
+       u8 lut_bits = LUT_BITS_DEFAULT;

Please fix this double assignment like shown in the comment for patch [4/9].

Thanks,
Angelo