Sometimes drivers are missing logs when they return EINVAL.
Printing the failure here in common code can help understand where
EINVAL is coming from.

All other atomic_check() calls in this file already have similar
logging.

v2: add missing newlines

Signed-off-by: Simon Ser <cont...@emersion.fr>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Lyude Paul <ly...@redhat.com>
---
 drivers/gpu/drm/drm_atomic_helper.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_atomic_helper.c 
b/drivers/gpu/drm/drm_atomic_helper.c
index c6abfd3d4b62..4aa05b626b57 100644
--- a/drivers/gpu/drm/drm_atomic_helper.c
+++ b/drivers/gpu/drm/drm_atomic_helper.c
@@ -702,8 +702,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
 
                if (funcs->atomic_check)
                        ret = funcs->atomic_check(connector, state);
-               if (ret)
+               if (ret) {
+                       drm_dbg_atomic(dev,
+                                      "[CONNECTOR:%d:%s] driver check 
failed\n",
+                                      connector->base.id, connector->name);
                        return ret;
+               }
 
                connectors_mask |= BIT(i);
        }
@@ -745,8 +749,12 @@ drm_atomic_helper_check_modeset(struct drm_device *dev,
 
                if (funcs->atomic_check)
                        ret = funcs->atomic_check(connector, state);
-               if (ret)
+               if (ret) {
+                       drm_dbg_atomic(dev,
+                                      "[CONNECTOR:%d:%s] driver check 
failed\n",
+                                      connector->base.id, connector->name);
                        return ret;
+               }
        }
 
        /*
-- 
2.37.2


Reply via email to