Hello Thomas,
On 7/21/22 10:16, Thomas Zimmermann wrote:
> Reverse the order of the final two arguments when calling
> aperture_remove_conflicting_devices(). An error report is available
> at [1].
>
> Reported-by: kernel test robot <l...@intel.com>
> Signed-off-by: Thomas Zimmermann <tzimmerm...@suse.de>
> Fixes: 8d69d008f44c ("fbdev: Convert drivers to aperture helpers")
> Cc: Thomas Zimmermann <tzimmerm...@suse.de>
> Cc: Javier Martinez Canillas <javi...@redhat.com>
> Cc: Sudip Mukherjee <sudipm.mukher...@gmail.com>
> Cc: Teddy Wang <teddy.w...@siliconmotion.com>
> Cc: Benjamin Herrenschmidt <b...@kernel.crashing.org>
> Cc: "K. Y. Srinivasan" <k...@microsoft.com>
> Cc: Haiyang Zhang <haiya...@microsoft.com>
> Cc: Stephen Hemminger <sthem...@microsoft.com>
> Cc: Wei Liu <wei....@kernel.org>
> Cc: Dexuan Cui <de...@microsoft.com>
> Cc: linux-fb...@vger.kernel.org
> Cc: linux-hyp...@vger.kernel.org
> Link: https://lore.kernel.org/lkml/202207202040.js1wctzn-...@intel.com/ # 1
> ---
> drivers/video/fbdev/aty/radeon_base.c | 2 +-
> drivers/video/fbdev/hyperv_fb.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/aty/radeon_base.c
> b/drivers/video/fbdev/aty/radeon_base.c
> index e5e362b8c9da..0a8199985d52 100644
> --- a/drivers/video/fbdev/aty/radeon_base.c
> +++ b/drivers/video/fbdev/aty/radeon_base.c
> @@ -2243,7 +2243,7 @@ static int radeon_kick_out_firmware_fb(struct pci_dev
> *pdev)
> resource_size_t base = pci_resource_start(pdev, 0);
> resource_size_t size = pci_resource_len(pdev, 0);
>
> - return aperture_remove_conflicting_devices(base, size, KBUILD_MODNAME,
> false);
> + return aperture_remove_conflicting_devices(base, size, false,
> KBUILD_MODNAME);
> }
I also missed that the order wasn't correct when reviewing.
Reviewed-by: Javier Martinez Canillas <javi...@redhat.com>
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
