Hi,
On Tue, Jul 19, 2022 at 1:39 PM Nícolas F. R. A. Prado
<nfrapr...@collabora.com> wrote:
>
> The value read from the "hpd-absent-delay-ms" property in DT was being
> saved to the wrong variable, overriding the hpd_reliable delay. Fix the
> typo.
>
> Fixes: 5540cf8f3e8d ("drm/panel-edp: Implement generic "edp-panel"s probed by
> EDID")
> Signed-off-by: Nícolas F. R. A. Prado <nfrapr...@collabora.com>
> ---
>
> drivers/gpu/drm/panel/panel-edp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-edp.c
> b/drivers/gpu/drm/panel/panel-edp.c
> index 152e00eb846f..b3536d8600f4 100644
> --- a/drivers/gpu/drm/panel/panel-edp.c
> +++ b/drivers/gpu/drm/panel/panel-edp.c
> @@ -738,7 +738,7 @@ static int generic_edp_panel_probe(struct device *dev,
> struct panel_edp *panel)
> of_property_read_u32(dev->of_node, "hpd-reliable-delay-ms",
> &reliable_ms);
> desc->delay.hpd_reliable = reliable_ms;
> of_property_read_u32(dev->of_node, "hpd-absent-delay-ms", &absent_ms);
> - desc->delay.hpd_reliable = absent_ms;
> + desc->delay.hpd_absent = absent_ms;
Well that's embarrassing. In the end I never used any of these
properties for anything shipping since HPD was always hooked up on
later boards and the only board that needed "hpd_reliable" never ended
up switching to the generic "edp-panel".
Reviewed-by: Douglas Anderson <diand...@chromium.org>
I'll apply this right away to drm-misc-fixes.
