The second operand of a '&&' operator has no impact on expression
result for cases 400 and 512 in SiS_GetModeID().

Judging by the logic and the names of the variables, in both cases a
typo was made.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Signed-off-by: Rustam Subkhankulov <subkhanku...@ispras.ru>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
---
 drivers/video/fbdev/sis/init.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/sis/init.c b/drivers/video/fbdev/sis/init.c
index b568c646a76c..2ba91d62af92 100644
--- a/drivers/video/fbdev/sis/init.c
+++ b/drivers/video/fbdev/sis/init.c
@@ -355,12 +355,12 @@ SiS_GetModeID(int VGAEngine, unsigned int VBFlags, int 
HDisplay, int VDisplay,
                }
                break;
        case 400:
-               if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDwidth 
>= 600))) {
+               if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 800) && (LCDheight 
>= 600))) {
                        if(VDisplay == 300) ModeIndex = 
ModeIndex_400x300[Depth];
                }
                break;
        case 512:
-               if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && (LCDwidth 
>= 768))) {
+               if((!(VBFlags & CRT1_LCDA)) || ((LCDwidth >= 1024) && 
(LCDheight >= 768))) {
                        if(VDisplay == 384) ModeIndex = 
ModeIndex_512x384[Depth];
                }
                break;
-- 
2.25.1

Reply via email to