On Wed, 13 Jul 2022, Andy Shevchenko wrote: > On Wed, Jul 13, 2022 at 12:53 PM ChiaEn Wu <peterwu....@gmail.com> wrote: > > Andy Shevchenko <andy.shevche...@gmail.com> 於 2022年7月5日 週二 清晨5:14寫道： > > > On Mon, Jul 4, 2022 at 7:43 AM ChiaEn Wu <peterwu....@gmail.com> wrote: > > Please, remove unneeded context when replying! > > ... > > > > > + brightness_val[0] = (brightness - 1) & > > > > MT6370_BL_DIM2_MASK; > > > > + brightness_val[1] = (brightness - 1) > > > > + >> fls(MT6370_BL_DIM2_MASK); > > > > > > Bad indentation. One line? > > > > Well... if indent to one line, it will be over 80 characters(or called > > columns?) > > From my understanding, it is not allowed, right?? > > It's allowed to some extent.Use your common sense. > Here it's obviously broken indentation.
Refrain from going crazy though - hard limit is 100 chars. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
