devm_pm_runtime_enable() simplifies the driver a bit since it will call
pm_runtime_disable() automatically through a device-managed action.

Signed-off-by: Maxime Ripard <max...@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_vec.c | 20 +++++---------------
 1 file changed, 5 insertions(+), 15 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_vec.c b/drivers/gpu/drm/vc4/vc4_vec.c
index 2a72644d99c5..a75b82de3796 100644
--- a/drivers/gpu/drm/vc4/vc4_vec.c
+++ b/drivers/gpu/drm/vc4/vc4_vec.c
@@ -583,39 +583,29 @@ static int vc4_vec_bind(struct device *dev, struct device 
*master, void *data)
                return ret;
        }
 
-       pm_runtime_enable(dev);
+       ret = devm_pm_runtime_enable(dev);
+       if (ret)
+               return ret;
 
        ret = drmm_simple_encoder_init(drm, &vec->encoder.base, 
DRM_MODE_ENCODER_TVDAC);
        if (ret)
-               goto err_put_runtime_pm;
+               return ret;
 
        drm_encoder_helper_add(&vec->encoder.base, 
&vc4_vec_encoder_helper_funcs);
 
        ret = vc4_vec_connector_init(drm, vec);
        if (ret)
-               goto err_put_runtime_pm;
+               return ret;
 
        dev_set_drvdata(dev, vec);
 
        vc4_debugfs_add_regset32(drm, "vec_regs", &vec->regset);
 
        return 0;
-
-err_put_runtime_pm:
-       pm_runtime_disable(dev);
-
-       return ret;
-}
-
-static void vc4_vec_unbind(struct device *dev, struct device *master,
-                          void *data)
-{
-       pm_runtime_disable(dev);
 }
 
 static const struct component_ops vc4_vec_ops = {
        .bind   = vc4_vec_bind,
-       .unbind = vc4_vec_unbind,
 };
 
 static int vc4_vec_dev_probe(struct platform_device *pdev)
-- 
2.36.1

Reply via email to