devm_pm_runtime_enable() simplifies the driver a bit since it will call
pm_runtime_disable() automatically through a device-managed action.

Signed-off-by: Maxime Ripard <max...@cerno.tech>
---
 drivers/gpu/drm/vc4/vc4_dsi.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c
index 282537f27b8e..741db2dce8ab 100644
--- a/drivers/gpu/drm/vc4/vc4_dsi.c
+++ b/drivers/gpu/drm/vc4/vc4_dsi.c
@@ -1622,6 +1622,10 @@ static int vc4_dsi_bind(struct device *dev, struct 
device *master, void *data)
 
        drm_encoder_helper_add(encoder, &vc4_dsi_encoder_helper_funcs);
 
+       ret = devm_pm_runtime_enable(dev);
+       if (ret)
+               return ret;
+
        ret = drm_bridge_attach(encoder, dsi->bridge, NULL, 0);
        if (ret)
                return ret;
@@ -1634,8 +1638,6 @@ static int vc4_dsi_bind(struct device *dev, struct device 
*master, void *data)
 
        vc4_debugfs_add_regset32(drm, dsi->variant->debugfs_name, &dsi->regset);
 
-       pm_runtime_enable(dev);
-
        return 0;
 }
 
@@ -1645,8 +1647,6 @@ static void vc4_dsi_unbind(struct device *dev, struct 
device *master,
        struct vc4_dsi *dsi = dev_get_drvdata(dev);
        struct drm_encoder *encoder = &dsi->encoder.base;
 
-       pm_runtime_disable(dev);
-
        /*
         * Restore the bridge_chain so the bridge detach procedure can happen
         * normally.
-- 
2.36.1

Reply via email to